From f9f72c9d4a8c46587d06ba7c95c07d889be2c803 Mon Sep 17 00:00:00 2001 From: Ibrahim Zidan Date: Sat, 4 Apr 2020 01:44:39 +0200 Subject: Fix quest info copying npc_data instead of storing it pointer, resulting in always false comparison and even possible memory violation access Signed-off-by: Ibrahim Zidan --- src/map/quest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/map/quest.c') diff --git a/src/map/quest.c b/src/map/quest.c index 10ea668a6..217acfa19 100644 --- a/src/map/quest.c +++ b/src/map/quest.c @@ -675,7 +675,7 @@ static void quest_questinfo_refresh(struct map_session_data *sd) nullpo_retv(sd); for (int i = 0; i < VECTOR_LENGTH(map->list[sd->bl.m].qi_list); i++) { - struct npc_data *nd = &VECTOR_INDEX(map->list[sd->bl.m].qi_list, i); + struct npc_data *nd = VECTOR_INDEX(map->list[sd->bl.m].qi_list, i); int j; ARR_FIND(0, VECTOR_LENGTH(nd->qi_data), j, quest->questinfo_validate(sd, &VECTOR_INDEX(nd->qi_data, j)) == true); -- cgit v1.2.3-70-g09d2