From 08922748cfc4cd30cbe5d2e6bdee9f2f7c4c7c39 Mon Sep 17 00:00:00 2001 From: Kenpachi Developer Date: Fri, 1 May 2020 08:41:11 +0200 Subject: Adjust size of fields holding a string variable's value to SCRIPT_STRING_VAR_LENGTH + 1 Also exclude NULL-terminator from string variable value length in inter-server communication. --- src/char/char.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src/char/char.c') diff --git a/src/char/char.c b/src/char/char.c index aac9ad20c..5af83ce9e 100644 --- a/src/char/char.c +++ b/src/char/char.c @@ -2898,13 +2898,13 @@ static void char_global_accreg_to_login_add(const char *key, unsigned int index, if( val ) { char *sval = (char*)val; - len = strlen(sval)+1; + len = strlen(sval); - WFIFOB(chr->login_fd, nlen) = (unsigned char)len;/* won't be higher; the column size is 254 */ + WFIFOB(chr->login_fd, nlen) = (unsigned char)len; // Won't be higher; the column size is 255. nlen += 1; - safestrncpy(WFIFOP(chr->login_fd,nlen), sval, len); - nlen += len; + safestrncpy(WFIFOP(chr->login_fd, nlen), sval, len + 1); + nlen += len + 1; } } else { WFIFOB(chr->login_fd, nlen) = val ? 0 : 1; -- cgit v1.2.3-60-g2f50