From 9e62c33d9ee58d7dcf1c667a77b3fdd814bc0943 Mon Sep 17 00:00:00 2001 From: Lance Date: Mon, 29 May 2006 09:53:45 +0000 Subject: [Optimized] - Removed unused checks for unsigned data type and possible logic error for char type (gcc treats char as unsigned). git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@6814 54d463be-8e91-2dee-dedb-b68131a5f0ec --- src/common/grfio.c | 2 +- src/common/showmsg.c | 2 +- src/common/socket.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) (limited to 'src/common') diff --git a/src/common/grfio.c b/src/common/grfio.c index 41e6864ae..aa677a0e5 100644 --- a/src/common/grfio.c +++ b/src/common/grfio.c @@ -68,7 +68,7 @@ typedef struct { char type; char fn[128-4*5]; // file name char *fnd; - char gentry; // read grf file select + signed char gentry; // read grf file select } FILELIST; //gentry ... 0 : It acquires from a local file. // It acquires from the resource file of 1>=:gentry_table[gentry-1]. diff --git a/src/common/showmsg.c b/src/common/showmsg.c index 7d940b189..03dcb7e8a 100644 --- a/src/common/showmsg.c +++ b/src/common/showmsg.c @@ -52,7 +52,7 @@ int _vShowMessage(enum msg_type flag, const char *string, va_list ap) return 1; } - if (timestamp_format) + if (strlen(timestamp_format) > 0) { //Display time format. [Skotlex] time_t t = time(NULL); strftime(prefix, 80, timestamp_format, localtime(&t)); diff --git a/src/common/socket.c b/src/common/socket.c index 2558e83ac..8fba86e0e 100644 --- a/src/common/socket.c +++ b/src/common/socket.c @@ -1210,7 +1210,7 @@ int RFIFOSKIP(int fd,int len) s = session[fd]; - if (s->rdata_size-s->rdata_pos-len<0) { + if ((signed int)(s->rdata_size-s->rdata_pos-len)<0) { //fprintf(stderr,"too many skip\n"); //exit(1); //better than a COMPLETE program abort // TEST! :) -- cgit v1.2.3-70-g09d2