From d9b3b016e2bfb0b70a4e292f1e73f7c2b94767aa Mon Sep 17 00:00:00 2001 From: Dastgir Date: Sun, 7 Oct 2018 13:56:05 +0530 Subject: Removed unused variable from utils.py --- tools/utils/common.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/utils/common.py b/tools/utils/common.py index 7b7811654..96fd3b3c5 100644 --- a/tools/utils/common.py +++ b/tools/utils/common.py @@ -55,7 +55,6 @@ def LoadDB(DBname, mode, serverpath): if os.path.isfile(serverpath + 'db/{}2.conf'.format(DBname)): filenames.append(serverpath + 'db/{}2.conf'.format(DBname)) - consts = dict() for filename in filenames: with io.open(filename) as f: config = libconf.load(f) -- cgit v1.2.3-60-g2f50 From 4390ad0d55be30eae0d70813cbc471d76539f2fa Mon Sep 17 00:00:00 2001 From: Dastgir Date: Sun, 7 Oct 2018 13:58:14 +0530 Subject: Python: Explicitely truncate value to int --- tools/mobdbconverter.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/mobdbconverter.py b/tools/mobdbconverter.py index 78047aed9..525952976 100755 --- a/tools/mobdbconverter.py +++ b/tools/mobdbconverter.py @@ -188,7 +188,7 @@ def convertFile(inFile, itemDb): printField("ChaseRange", fields[21]) printField("Size", fields[22]) printField("Race", fields[23]) - print("\tElement: ({0}, {1})".format(int(fields[24]) % 10, int(fields[24]) / 20)); + print("\tElement: ({0}, {1})".format(int(fields[24]) % 10, int(int(fields[24]) / 20))); mode = int(fields[25], 0) if mode != 0: startGroup("Mode") -- cgit v1.2.3-60-g2f50 From 838d12f50e5a78f271a67292141b463404a33fe4 Mon Sep 17 00:00:00 2001 From: Dastgir Date: Sun, 7 Oct 2018 13:59:09 +0530 Subject: Removing the use of Equivalence operator in utils.py --- tools/utils/common.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/utils/common.py b/tools/utils/common.py index 96fd3b3c5..acceb9b30 100644 --- a/tools/utils/common.py +++ b/tools/utils/common.py @@ -35,13 +35,13 @@ def LoadDBConsts(DBname, mode, serverpath): with io.open(filename) as f: config = libconf.load(f) db = config[DBname] - if DBname is 'item_db': + if DBname == 'item_db': for i, v in enumerate(db): consts[db[i].Id] = db[i].AegisName - elif DBname is 'mob_db': + elif DBname == 'mob_db': for i, v in enumerate(db): consts[db[i].Id] = db[i].SpriteName - elif DBname is 'skill_db': + elif DBname == 'skill_db': for i, v in enumerate(db): consts[db[i].Id] = db[i].Name else: -- cgit v1.2.3-60-g2f50 From 9e879ea913ec93212ebd46f56990d1e90209b32a Mon Sep 17 00:00:00 2001 From: Dastgir Date: Sun, 7 Oct 2018 14:02:16 +0530 Subject: Fixes LGTM Alert: Added Exceptions --- tools/mobdbconverter.py | 2 +- tools/mobskilldbconverter.py | 2 +- tools/petdbconverter.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/mobdbconverter.py b/tools/mobdbconverter.py index 525952976..683e28274 100755 --- a/tools/mobdbconverter.py +++ b/tools/mobdbconverter.py @@ -260,7 +260,7 @@ def readItemDB(inFile, itemDb): elif line[:3] == "Id:": try: itemId = int(line[4:]) - except: + except ValueError: started = False if itemId != 0 and itemName != "": # was need for remove wrong characters diff --git a/tools/mobskilldbconverter.py b/tools/mobskilldbconverter.py index 310331043..4ba042062 100644 --- a/tools/mobskilldbconverter.py +++ b/tools/mobskilldbconverter.py @@ -206,7 +206,7 @@ def LoadOldDB(mode, serverpath): continue try: Db[MonsterId][skillidx]['val{}'.format(i)] = int(entry[12 + i]) - except: + except ValueError: Db[MonsterId][skillidx]['val{}'.format(i)] = int(entry[12 + i], 16) Db[MonsterId][skillidx]['Emotion'] = entry[17] Db[MonsterId][skillidx]['ChatMsgID'] = entry[18] diff --git a/tools/petdbconverter.py b/tools/petdbconverter.py index 261c1e6ad..1b7d2e4d6 100644 --- a/tools/petdbconverter.py +++ b/tools/petdbconverter.py @@ -175,7 +175,7 @@ def readItemDB(inFile, itemDb): elif line[:3] == "Id:": try: itemId = int(line[4:]) - except: + except ValueError: started = False if itemId != 0 and itemName != "": # was need for remove wrong characters -- cgit v1.2.3-60-g2f50