From bfa44d6b007ca2e3ffabafda5beadbf102a6efdc Mon Sep 17 00:00:00 2001 From: Andrei Karas Date: Sat, 2 Mar 2013 21:17:53 +0300 Subject: Other fixes from Coverity checks. --- src/resources/atlasmanager.cpp | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) (limited to 'src/resources/atlasmanager.cpp') diff --git a/src/resources/atlasmanager.cpp b/src/resources/atlasmanager.cpp index 9ff01b9c4..0d43d59c8 100644 --- a/src/resources/atlasmanager.cpp +++ b/src/resources/atlasmanager.cpp @@ -256,14 +256,15 @@ SDL_Surface *AtlasManager::createSDLAtlas(TextureAtlas *atlas) void AtlasManager::convertAtlas(TextureAtlas *atlas) { + // no check for null pointer in atlas because it was in caller // convert surface to OpemGL image atlas->atlasImage = imageHelper->load(atlas->surface); Image *const image = atlas->atlasImage; - if (image) - { - image->mIdPath = atlas->name; - image->incRef(); - } + if (!image) + return; + + image->mIdPath = atlas->name; + image->incRef(); FOR_EACH (std::vector::iterator, it, atlas->items) { -- cgit v1.2.3-60-g2f50