From 231d34905f2a24faff79f6ed805ef89f17caf96b Mon Sep 17 00:00:00 2001 From: Andrei Karas Date: Mon, 17 Aug 2015 22:13:43 +0300 Subject: Fix false positives like this: var = &expr; --- src/analysis/expression.cpp | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/analysis/expression.cpp b/src/analysis/expression.cpp index 7b2b897..509faa0 100644 --- a/src/analysis/expression.cpp +++ b/src/analysis/expression.cpp @@ -1078,12 +1078,22 @@ bool handleSetVarToFunction(const VarItem &var, if (node2 == ADDR_EXPR) { + if (node1 == VAR_DECL) + { + // var = &expr; + VarDeclNode *varDecl = static_cast(node1); + if (skipNop(varDecl->varType) == POINTER_TYPE) + { + addNonNullVar(wo, var.name); + return true; + } + } AddrExprNode *addr = static_cast(node2); if (!addr->args.empty() && skipNop(addr->args[0]) == VAR_DECL) { - VarDeclNode *varDecl = static_cast(skipNop(addr->args[0])); if (!var.isNonNull) { + VarDeclNode *varDecl = static_cast(skipNop(addr->args[0])); if (skipNop(varDecl->varType) != POINTER_TYPE) addNonNullVar(wo, var.name); else -- cgit v1.2.3-60-g2f50