From b4a8d4b0db33d074df0d7489e52f64964b2bf8ca Mon Sep 17 00:00:00 2001
From: Andrei Karas <akaras@inbox.ru>
Date: Sun, 6 Jun 2010 16:08:19 +0300
Subject: Fix memory leak in setup_players
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Reviewed-by: Thorbjørn Lindeijer
---
 src/gui/setup_players.cpp | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

(limited to 'src')

diff --git a/src/gui/setup_players.cpp b/src/gui/setup_players.cpp
index 06bae0ef..802a5b2e 100644
--- a/src/gui/setup_players.cpp
+++ b/src/gui/setup_players.cpp
@@ -35,6 +35,7 @@
 #include "gui/widgets/scrollarea.h"
 #include "gui/widgets/table.h"
 
+#include "utils/dtor.h"
 #include "utils/gettext.h"
 
 #include <string>
@@ -88,7 +89,8 @@ class PlayerTableModel : public TableModel
 {
 public:
     PlayerTableModel() :
-        mPlayers(NULL)
+        mPlayers(NULL),
+        mListModel(new PlayerRelationListModel)
     {
         playerRelationsUpdated();
     }
@@ -96,6 +98,7 @@ public:
     virtual ~PlayerTableModel()
     {
         freeWidgets();
+        delete mListModel;
         if (mPlayers)
             delete mPlayers;
     }
@@ -139,9 +142,8 @@ public:
             std::string name = (*player_names)[r];
             gcn::Widget *widget = new Label(name);
             mWidgets.push_back(widget);
-            gcn::ListModel *playerRelation = new PlayerRelationListModel;
 
-            gcn::DropDown *choicebox = new DropDown(playerRelation);
+            gcn::DropDown *choicebox = new DropDown(mListModel);
             choicebox->setSelected(player_relations.getRelation(name));
             mWidgets.push_back(choicebox);
         }
@@ -170,12 +172,7 @@ public:
             delete mPlayers;
         mPlayers = NULL;
 
-        for (std::vector<gcn::Widget *>::const_iterator it = mWidgets.begin();
-             it != mWidgets.end(); it++)
-        {
-            delete *it;
-        }
-
+        delete_all(mWidgets);
         mWidgets.clear();
     }
 
@@ -187,6 +184,7 @@ public:
 protected:
     std::vector<std::string> *mPlayers;
     std::vector<gcn::Widget *> mWidgets;
+    PlayerRelationListModel *mListModel;
 };
 
 /**
-- 
cgit v1.2.3-70-g09d2