From dc3b7dc6001c64bd9473518299c74f292b521516 Mon Sep 17 00:00:00 2001 From: Thorbjørn Lindeijer Date: Mon, 22 Feb 2010 22:08:44 +0100 Subject: Warn when receiving an empty update host Reviewed-by: Jared Adams --- src/net/manaserv/loginhandler.cpp | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) (limited to 'src/net') diff --git a/src/net/manaserv/loginhandler.cpp b/src/net/manaserv/loginhandler.cpp index cbc8e510..b3c70226 100644 --- a/src/net/manaserv/loginhandler.cpp +++ b/src/net/manaserv/loginhandler.cpp @@ -22,6 +22,7 @@ #include "net/manaserv/loginhandler.h" #include "client.h" +#include "log.h" #include "net/logindata.h" @@ -321,11 +322,16 @@ void LoginHandler::handleRegisterResponse(Net::MessageIn &msg) void LoginHandler::readUpdateHost(Net::MessageIn &msg) { + // Safety check for outdated manaserv versions (remove me later) + if (msg.getUnreadLength() == 0) + return; + // Set the update host when included in the message - if (msg.getUnreadLength() > 0) - { - mLoginData->updateHost = msg.readString(); - } + const std::string updateHost = msg.readString(); + if (!updateHost.empty()) + mLoginData->updateHost = updateHost; + else + logger->log("Warning: server does not have an update host set!"); } void LoginHandler::connect() -- cgit v1.2.3-60-g2f50