From 4e27937924766948d7ff9200f04a37fe4d59018c Mon Sep 17 00:00:00 2001 From: Thorbjørn Lindeijer Date: Thu, 2 Jun 2011 00:32:53 +0200 Subject: Arbitrary code cleanups Just some stuff that piles up while "looking" at the code, which eventually gets annoying to ignore while staging real changes. * Replaced a few NULL occurrences with 0 * Rely on default parameter for std::vector::resize. * Replaced a few "" with std::string() * Prefer .empty() to == "" * Removed a few comparisons with NULL * Don't check pointers before deleting them * Removed a bunch of redundant semicolons * Made some global variables static (local to their compilation unit) * Prefer prefix ++/-- operators to postfix versions when possible * Corrected location of a comment --- src/gui/ministatus.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'src/gui/ministatus.cpp') diff --git a/src/gui/ministatus.cpp b/src/gui/ministatus.cpp index 0fdf59b1..f3a8b807 100644 --- a/src/gui/ministatus.cpp +++ b/src/gui/ministatus.cpp @@ -92,11 +92,9 @@ MiniStatusWindow::MiniStatusWindow(): void MiniStatusWindow::setIcon(int index, AnimatedSprite *sprite) { if (index >= (int) mIcons.size()) - mIcons.resize(index + 1, NULL); - - if (mIcons[index]) - delete mIcons[index]; + mIcons.resize(index + 1); + delete mIcons[index]; mIcons[index] = sprite; } -- cgit v1.2.3-70-g09d2