From 1bb03e1549a9050049bc027566a448a530298b64 Mon Sep 17 00:00:00 2001 From: FlavioJS Date: Sat, 22 Nov 2008 23:54:34 +0000 Subject: * Hunted down improper uses of va_list variables. git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@13383 54d463be-8e91-2dee-dedb-b68131a5f0ec --- src/common/showmsg.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) (limited to 'src/common/showmsg.c') diff --git a/src/common/showmsg.c b/src/common/showmsg.c index c50716bed..fc1badd26 100644 --- a/src/common/showmsg.c +++ b/src/common/showmsg.c @@ -673,6 +673,7 @@ char timestamp_format[20] = ""; //For displaying Timestamps int _vShowMessage(enum msg_type flag, const char *string, va_list ap) { + va_list apcopy; char prefix[100]; #if defined(DEBUGLOGMAP) || defined(DEBUGLOGCHAR) || defined(DEBUGLOGLOGIN) FILE *fp; @@ -734,12 +735,16 @@ int _vShowMessage(enum msg_type flag, const char *string, va_list ap) if (flag == MSG_ERROR || flag == MSG_FATALERROR || flag == MSG_SQL) { //Send Errors to StdErr [Skotlex] FPRINTF(STDERR, "%s ", prefix); - VFPRINTF(STDERR, string, ap); + va_copy(apcopy, ap); + VFPRINTF(STDERR, string, apcopy); + va_end(apcopy); FFLUSH(STDERR); } else { if (flag != MSG_NONE) FPRINTF(STDOUT, "%s ", prefix); - VFPRINTF(STDOUT, string, ap); + va_copy(apcopy, ap); + VFPRINTF(STDOUT, string, apcopy); + va_end(apcopy); FFLUSH(STDOUT); } @@ -751,7 +756,9 @@ int _vShowMessage(enum msg_type flag, const char *string, va_list ap) FFLUSH(STDERR); } else { fprintf(fp,"%s ", prefix); - vfprintf(fp,string,ap); + va_copy(apcopy, ap); + vfprintf(fp,string,apcopy); + va_end(apcopy); fclose(fp); } } else { @@ -760,7 +767,6 @@ int _vShowMessage(enum msg_type flag, const char *string, va_list ap) } #endif - va_end(ap); return 0; } -- cgit v1.2.3-70-g09d2