Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
source
now defining new parameters in the constants.conf database is deprecated
and should be defined in source instead
|
|
Add new logging types.
|
|
|
|
Fixes #1114
|
|
Check allowed range for "View" field in item_db for weapon items.
|
|
Also fix some array sizes.
|
|
- In the numeric format, certain valid masks (greater than 0x7fffffff)
could fail to process
- In the textual format, masks having "All" in a position other than
the first, would reset any preceding jobs.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- Under certain unpredictable conditions, a #command could be applied
to a character other than the specified.
Signed-off-by: Haru <haru@dotalux.com>
|
|
|
|
|
|
|
|
https://github.com/HerculesWS/Hercules/commit/f95290cc2396d791ad3e9e9f5f73980887a5ef95.
|
|
|
|
|
|
more meaningful variable names in battle_calc_damage()
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
- The functions were returning `(bool)-1` instead of `false` in case of
error, or `(bool)0` instead of `true` in case of success.
Signed-off-by: Haru <haru@dotalux.com>
|
|
INFINITE_DURATION, INVALID_TIMER, SC_NONE, INDEX_NOT_FOUND, depending on context.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- The variable should be signed, since it uses the value -1 to indicate
infinite duration (and it's stored as signed in the database).
- Added #define for the special value -1 (INFINITE_DURATION).
- This fixes an issue causing status changes to fail being saved to
database (thanks to Michi for reporting it).
- Related to commit 8dc75721.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- The npc-side code no longer depends on the client data layout.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- The npc-side code no longer depends on the client data layout.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- The npc-side code no longer depends on the client data layout.
Signed-off-by: Haru <haru@dotalux.com>
|
|
struct itemlist
- The skill-side code no longer depends on the client packet data layout.
- Some data validation has been added.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- The npc-side code no longer depends on the client packet data layout.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- To be used in various non-clif functions that right now take client
data buffers directly.
Signed-off-by: Haru <haru@dotalux.com>
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
- WBUFP now returns a pointer to void, which automatically casts to any
non-const or const pointer.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- This is necessary for compatibility with a const RP2PTR/RFIFO2PTR
Signed-off-by: Haru <haru@dotalux.com>
|
|
- While this is arguable, those explicit typecasts are potentially
dangerous/misleading (for example, a const specifier might get
accidentally dropped without even generating a compiler warning, or a
variable type might change during code changes, and any related
warning would get silenced by the explicit typecast).
- As a reminder Hercules is written in C, and not in C++ (and there's
no such thing as "compiling in C++ mode" - they're two different
languages.) As such, it is legal to let the compiler automatically
promote void* from/to any non-const pointer type, as well as const
void* from/to any const pointer type.
Signed-off-by: Haru <haru@dotalux.com>
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
Now it no longer needs to memcpy data to a temporary buffer.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- This is necessary for compatibility with a const RFIFOP.
Signed-off-by: Haru <haru@dotalux.com>
|
|
A read FIFO/buffer should be, well, read-only.
Signed-off-by: Haru <haru@dotalux.com>
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
- Changed literal 1L values used in unit64 bit-shift operations to 1ULL.
- Follow-up to f606519c3b611573ade246ec82db26437bf03668 (reported by
zackdreaver)
Signed-off-by: Haru <haru@dotalux.com>
|
|
Reported in http://herc.ws/board/topic/11994-map-crashed-on-friendly-poring-quest-novice-quest/
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
|
|
|
|
Also add compiler flag for check for missing noreturn attributes.
|
|
Add all missing -Wformat flags into configure.
|
|
Add -Wcast-qual into configure comment.
|
|
Added some forgotten <stdio.h> and "common/conf.h" includes to .c files,
that were previously masked by the above.
Signed-off-by: Haru <haru@dotalux.com>
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
- The return value is now consistent with the libconfig standard
(CONFIG_TRUE/CONFIG_FALSE).
- Removed some redundant error messages.
Signed-off-by: Haru <haru@dotalux.com>
|
|
Related to #1152
Signed-off-by: Haru <haru@dotalux.com>
|