From c74680473e702bacc009897a258387445d6f3eb5 Mon Sep 17 00:00:00 2001 From: Thorbjørn Lindeijer Date: Wed, 6 Mar 2024 21:12:22 +0100 Subject: Use the native TMX tile animation format Rewrote the tile animation loading code based on XML tags, replacing the code that loaded tile animations from tile properties. Also made a number of code simplifications and optimizations: * Replaced a number of pointer members with value members. * Pass around Animation and TileAnimation by value, using std::move to avoid allocating copies. * push -> emplace * push_front -> emplace_front * push_back -> emplace_back * Use range-based for loops * Use std::vector instead of std::list for storing affected tiles (less fragmentation) * Avoid string copies and allocations while parsing CSV layer data. * Replaced xmlNodeGetContent with directly accessing 'content'. --- src/resources/animation.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'src/resources/animation.cpp') diff --git a/src/resources/animation.cpp b/src/resources/animation.cpp index 1be27c2c..b48e8cff 100644 --- a/src/resources/animation.cpp +++ b/src/resources/animation.cpp @@ -23,8 +23,12 @@ void Animation::addFrame(Image *image, int delay, int offsetX, int offsetY) { - Frame frame = { image, delay, offsetX, offsetY }; - mFrames.push_back(frame); + auto &frame = mFrames.emplace_back(); + frame.image = image; + frame.delay = delay; + frame.offsetX = offsetX; + frame.offsetY = offsetY; + mDuration += delay; } -- cgit v1.2.3-70-g09d2