From 396c966cd2b3af2dbdb5b157e9ebb2e576b677b0 Mon Sep 17 00:00:00 2001 From: Bjørn Lindeijer Date: Tue, 29 Apr 2008 12:58:21 +0000 Subject: When compiling with GCC, use the printf format attribute for the log method so that the compiler checks the type of its parameters. --- ChangeLog | 3 +++ src/log.h | 6 +++++- src/resources/imageset.cpp | 2 +- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index de3ae562..dcd84ffa 100644 --- a/ChangeLog +++ b/ChangeLog @@ -10,6 +10,9 @@ * src/gui/gccontainer.h, src/gui/gccontainer.cpp: Removed unused option from GCContainer to not delete a child, fixing warnings about hiding virtual method gcn::Container::add. + * src/log.h, src/resources/imageset.cpp: When compiling with GCC, use + the printf format attribute for the log method so that the compiler + checks the type of its parameters. 2008-04-28 Bjørn Lindeijer diff --git a/src/log.h b/src/log.h index dd1c0f91..6fe9dccd 100644 --- a/src/log.h +++ b/src/log.h @@ -61,7 +61,11 @@ class Logger /** * Enters a message in the log. The message will be timestamped. */ - void log(const char *log_text, ...); + void log(const char *log_text, ...) +#ifdef __GNUC__ + __attribute__((__format__(__printf__, 2, 3))) +#endif + ; /** * Log an error and quit. The error will pop-up in Windows and will be diff --git a/src/resources/imageset.cpp b/src/resources/imageset.cpp index 08a6a110..4b6dd592 100644 --- a/src/resources/imageset.cpp +++ b/src/resources/imageset.cpp @@ -54,7 +54,7 @@ ImageSet::get(size_type i) { if (i >= mImages.size()) { - logger->log("Warning: Sprite #%i does not exist in this image set", i); + logger->log("Warning: No sprite %d in this image set", (int) i); return NULL; } else -- cgit v1.2.3-70-g09d2