From 36ba43d6ea38062b17f7e63ef659962bfc51c64d Mon Sep 17 00:00:00 2001 From: Andrei Karas Date: Tue, 6 Jun 2017 23:34:34 +0300 Subject: Fix clang-tidy check readability-implicit-bool-cast. --- src/configmanager.cpp | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) (limited to 'src/configmanager.cpp') diff --git a/src/configmanager.cpp b/src/configmanager.cpp index 875431316..f9c7c447e 100644 --- a/src/configmanager.cpp +++ b/src/configmanager.cpp @@ -55,7 +55,7 @@ void ConfigManager::initServerConfig(const std::string &serverName) { settings.serverConfigDir = pathJoin(settings.configDir, serverName); - if (mkdir_r(settings.serverConfigDir.c_str())) + if (mkdir_r(settings.serverConfigDir.c_str()) != 0) { // TRANSLATORS: directory creation error logger->error(strprintf(_("%s doesn't exist and can't be created! " @@ -63,18 +63,18 @@ void ConfigManager::initServerConfig(const std::string &serverName) } const std::string configPath = settings.serverConfigDir + "/config.xml"; FILE *configFile = fopen(configPath.c_str(), "r"); - if (!configFile) + if (configFile == nullptr) { configFile = fopen(configPath.c_str(), "wb"); logger->log("Creating new server config: " + configPath); - if (configFile) + if (configFile != nullptr) { fputs("\n", configFile); fputs("\n", configFile); fputs("\n", configFile); } } - if (configFile) + if (configFile != nullptr) { fclose(configFile); serverConfig.init(configPath); @@ -143,18 +143,18 @@ void ConfigManager::initConfiguration() #endif // UNITTESTS FILE *configFile = fopen(configPath.c_str(), "r"); - if (!configFile) + if (configFile == nullptr) { configFile = fopen(configPath.c_str(), "wb"); logger->log1("Creating new config"); - if (configFile) + if (configFile != nullptr) { fputs("\n", configFile); fputs("\n", configFile); fputs("\n", configFile); } } - if (!configFile) + if (configFile == nullptr) { reportAlways("Can't create %s. Using defaults.", configPath.c_str()); -- cgit v1.2.3-70-g09d2