From e591d5b6d891516476aaf12808f4d3b3506e5f92 Mon Sep 17 00:00:00 2001
From: Ben Longbons <b.r.longbons@gmail.com>
Date: Sat, 5 Oct 2013 18:28:39 -0700
Subject: Remove direct packet buffer item assignments (not clones)

---
 src/login/login.cpp | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

(limited to 'src/login/login.cpp')

diff --git a/src/login/login.cpp b/src/login/login.cpp
index 679552a..c70c8d3 100644
--- a/src/login/login.cpp
+++ b/src/login/login.cpp
@@ -2607,12 +2607,14 @@ void parse_admin(int fd)
             case 0x7954:       // Request about information of an account (by account id)
                 if (RFIFOREST(fd) < 6)
                     return;
+            {
+                int account_id = RFIFOL(fd, 2);
                 WFIFOW(fd, 0) = 0x7953;
-                WFIFOL(fd, 2) = RFIFOL(fd, 2);
+                WFIFOL(fd, 2) = account_id;
                 WFIFO_ZERO(fd, 7, 24);
                 for (const AuthData& ad : auth_data)
                 {
-                    if (ad.account_id == RFIFOL(fd, 2))
+                    if (ad.account_id == account_id)
                     {
                         LOGIN_LOG("'ladmin': Sending information of an account (request by the id; account: %s, id: %d, ip: %s)\n",
                              ad.userid, RFIFOL(fd, 2), ip);
@@ -2641,6 +2643,7 @@ void parse_admin(int fd)
                     WFIFOW(fd, 148) = 0;
                     WFIFOSET(fd, 150);
                 }
+            }
             x7954_out:
                 RFIFOSKIP(fd, 6);
                 break;
-- 
cgit v1.2.3-60-g2f50