summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrei Karas <akaras@inbox.ru>2013-04-15 22:21:48 +0300
committerAndrei Karas <akaras@inbox.ru>2013-04-15 22:21:48 +0300
commit665e33246a82838dc8893e6b84a576de803a3195 (patch)
treeb1ec97a1295a0e493284c5538c7e255fde715817
parent890b38d266e9e90d85b04908fe733bddafd8fe8b (diff)
downloadmv-665e33246a82838dc8893e6b84a576de803a3195.tar.gz
mv-665e33246a82838dc8893e6b84a576de803a3195.tar.bz2
mv-665e33246a82838dc8893e6b84a576de803a3195.tar.xz
mv-665e33246a82838dc8893e6b84a576de803a3195.zip
improve iteminfo class.
-rw-r--r--src/resources/iteminfo.cpp6
-rw-r--r--src/resources/iteminfo.h4
2 files changed, 5 insertions, 5 deletions
diff --git a/src/resources/iteminfo.cpp b/src/resources/iteminfo.cpp
index 92df520ea..4ec5d81f9 100644
--- a/src/resources/iteminfo.cpp
+++ b/src/resources/iteminfo.cpp
@@ -84,7 +84,7 @@ const std::string &ItemInfo::getSprite(const Gender gender,
}
else
{
- static const std::string empty("");
+ static const std::string empty;
std::map<int, std::string>::const_iterator i =
mAnimationFiles.find(static_cast<int>(gender) + race * 4);
@@ -97,7 +97,7 @@ const std::string &ItemInfo::getSprite(const Gender gender,
}
}
-void ItemInfo::setAttackAction(std::string attackAction)
+void ItemInfo::setAttackAction(const std::string &attackAction)
{
if (attackAction.empty())
mAttackAction = SpriteAction::ATTACK; // (Equal to unarmed animation)
@@ -148,7 +148,7 @@ std::map<int, int> *ItemInfo::addReplaceSprite(const int sprite,
return &it->second;
}
-void ItemInfo::setColorsList(std::string name)
+void ItemInfo::setColorsList(const std::string &name)
{
if (name.empty())
{
diff --git a/src/resources/iteminfo.h b/src/resources/iteminfo.h
index 380624b7b..e5b6f96b8 100644
--- a/src/resources/iteminfo.h
+++ b/src/resources/iteminfo.h
@@ -178,7 +178,7 @@ class ItemInfo final
const std::string &getSprite(const Gender gender,
const int race) const A_WARN_UNUSED;
- void setAttackAction(std::string attackAction);
+ void setAttackAction(const std::string &attackAction);
// Handlers for seting and getting the string
// used for particles when attacking
@@ -275,7 +275,7 @@ class ItemInfo final
std::string getDyeColorsString(const int color) const A_WARN_UNUSED;
- void setColorsList(std::string name);
+ void setColorsList(const std::string &name);
bool isHaveColors() const A_WARN_UNUSED
{ return !mColorList.empty(); }