From bbc0fb7292460c7d383d16c25aa21bc68c06c27c Mon Sep 17 00:00:00 2001 From: Bjørn Lindeijer Date: Sat, 10 Jan 2009 00:57:09 +0100 Subject: Merged comment by silene from mainline We should probably look into fixing the thing he's talking about. --- src/gui/browserbox.cpp | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'src') diff --git a/src/gui/browserbox.cpp b/src/gui/browserbox.cpp index 8b222810..8be32ebb 100644 --- a/src/gui/browserbox.cpp +++ b/src/gui/browserbox.cpp @@ -352,6 +352,10 @@ BrowserBox::draw(gcn::Graphics *graphics) char const *hyphen = "~"; int hyphenWidth = font->getWidth(hyphen); + /* FIXME: This code layout makes it easy to crash remote + clients by talking garbage. Forged long utf-8 characters + will cause either a buffer underflow in substr or an + infinite loop in the main loop. */ do { if (!forced) -- cgit v1.2.3-70-g09d2